[Map] Introduce `ux_map.google_maps.default_map_id` configuration #2350

Kocal · 2024-11-07T19:15:30Z

Q	A
Bug fix?	no
New feature?	yes
Issues	Fix #2306
License	MIT

With this modification, I can configure a default Google Maps mapId:

# config/packages/ux_map.yaml
ux_map:
    # https://symfony.com/bundles/ux-map/current/index.html#available-renderers
    renderer: '%env(resolve:default::UX_MAP_DSN)%'
    google_maps:
        default_map_id: abcdefgh123456789

without having to manually pass the mapId when creating a Map:

// use default mapId
$map = (new Map());
    ->center(new Point(48.8566, 2.3522))
    ->zoom(6);

// use default mapId
$map2 = (clone $map)
    ->options(new GoogleOptions());

// use custom mapId
$map3 = (clone $map)
    ->options(new GoogleOptions(mapId: 'foobar));

src/Map/src/Bridge/Google/src/GoogleOptions.php

src/Map/CHANGELOG.md

src/Map/src/Bridge/Google/CHANGELOG.md

src/Map/src/Renderer/AbstractRenderer.php

src/Map/src/UXMapBundle.php

smnandre · 2024-11-07T19:51:37Z

src/Map/src/UXMapBundle.php

+                    ->set($rendererFactoryName = 'ux_map.renderer_factory.'.$name, $bridge['renderer_factory'])
                    ->parent('ux_map.renderer_factory.abstract')
                    ->tag('ux_map.renderer_factory');
+
+                if ('google' === $name) {
+                    $container->services()
+                        ->get($rendererFactoryName)


Not a big fan of variables in service names (just personal taste here)

carsonbot added Feature New Feature Map Status: Needs Review Needs to be reviewed labels Nov 7, 2024

[Map] Introduce ux_map.google_maps.default_map_id configuration

ddd5b54

Kocal force-pushed the 2306-feat branch from b159b02 to ddd5b54 Compare November 7, 2024 19:16

Kocal commented Nov 7, 2024

View reviewed changes

src/Map/src/Bridge/Google/src/GoogleOptions.php Show resolved Hide resolved